Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the new castor open function #289

Merged
merged 1 commit into from Mar 9, 2024
Merged

Use the new castor open function #289

merged 1 commit into from Mar 9, 2024

Conversation

JorickPepin
Copy link
Member

@lyrixx
Copy link
Member

lyrixx commented Mar 9, 2024

you need to bump the required version (\guard_min_version()`)

pyrech
pyrech approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

Could you also update the version in the min_guard_version call from the main castor.php?

@JorickPepin
Copy link
Member Author

There is no guard_min_version in castor.php, do I add one or do I add it directly in the task?

@lyrixx
Copy link
Member

lyrixx commented Mar 9, 2024 •
edited

Add global one. Thanks

lyrixx
lyrixx approved these changes Mar 9, 2024
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@lyrixx lyrixx merged commit 45b125f into main Mar 9, 2024
4 checks passed
@lyrixx lyrixx deleted the feat_open branch March 9, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

@pyrech pyrech pyrech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JorickPepin @lyrixx @pyrech