ci: better display in CI + introduce 'ci' context #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
commented
Mar 15, 2024
| @@ -287,7 +287,6 @@ function create_default_context(): Context | |||
| 'power_shell' => false, | |||
| 'user_id' => posix_geteuid(), | |||
| 'root_dir' => \dirname(__DIR__), | |||
| 'env' => $_SERVER['CI'] ?? false ? 'ci' : 'dev', | |||
There was a problem hiding this comment.
It does not make sens to have a "env" context when castor already has one.
| $data, | ||
| pty: Process::isPtySupported(), | ||
| environment: [ | ||
| 'BUILDKIT_PROGRESS' => 'plain', |
There was a problem hiding this comment.
Let's gather all env var here, to simplify CI configuration
| ]) | ||
| ->withEnvironment([ | ||
| 'BUILDKIT_PROGRESS' => 'plain', | ||
| 'COMPOSE_ANSI' => 'never', |
There was a problem hiding this comment.
The output is cleaner with this option in this CI. And it's much more digest
but, it does not work on github 😭
edit: hooo, pretty sure docker version on GH is too old 🤯
Let's keep it for now...
pyrech
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.