Do not wait for Elasticsearch reindex to finish #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanbr
reviewed
May 17, 2023
| @@ -84,6 +84,10 @@ public function migrate(Index $currentIndex, array $params = [], array $context | |||
| throw new RuntimeException(sprintf('Reindex call failed. %s', $response->getError())); | |||
| } | |||
|
|
|||
| if (!$waitForCompletion) { | |||
There was a problem hiding this comment.
You might also call $reindex->setWaitForCompletion() as well.
This may push some additional change in this method. The setWaitForCompletion() could always receive false, then this method performs what it needs based on the $waitForCompletion. Or we also could call setWaitForCompletion() passing $waitForCompletion value and let the lib do the "wait" for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a use case where I don't care that the Elasticsearch reindex is done before switching the index as live. So I would like to make this change.
Hope this is fine to you guys ? :)