Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to allow Symfony 7 and test on PHP 8.3 #180

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Update to allow Symfony 7 and test on PHP 8.3 #180

merged 6 commits into from
Jan 31, 2024

Conversation

NicolasDievart
Copy link
Contributor

Hi

I've updated the composer.json to allow Symfony ^7.0 and change the CI layout to test it against SF 7 but also 8.3 which release few days ago.

Do you want to keep supporting SF 5.4 (which ended its bug fixes period and entered security fix only https://symfony.com/releases/5.4) ? I can update this PR accordingly
I can also update to only allow 6.4 version instead of all 6.* if needed.

@damienalexandre
Copy link
Member

Hi! Thanks for the contribution ❤️

Yes I would like to keep Symfony 5.4 as it's the LTS version right now.

Looks like we have a dependency issue with Jane:

   Problem 1
    - Root composer.json requires jane-php/json-schema ^7.4 -> satisfiable by jane-php/json-schema[v7.4.0, ..., v7.5.5].
    - jane-php/json-schema[v7.4.0, ..., v7.5.5] require symfony/console ^4.4 || ^5.0 || ^6.0 -> found symfony/console[v4.4.0, ..., v4.4.49, v5.0.0, ..., v5.4.32, v6.0.0, ..., v6.4.1] but these were not loaded, likely because it conflicts with another require.
  Problem 2
    - jane-php/json-schema-runtime[v7.4.0, ..., v7.5.5] require symfony/serializer ^4.4 || ^5.0 || ^6.0 -> found symfony/serializer[v4.4.0, ..., v4.4.47, v5.0.0, ..., v5.4.33, v6.0.0, ..., v6.4.1] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires jane-php/json-schema-runtime ^7.4 -> satisfiable by jane-php/json-schema-runtime[v7.4.0, ..., v7.5.5].

@NicolasDievart
Copy link
Contributor Author

Good catch 👍
Will need this PR to be reviewed, merged and released then janephp/janephp#774

I let the PR as is with SF 5.4 :)

@insekticid
Copy link
Contributor

any news here?
janephp/janephp#774 has been merged!

@damienalexandre
Copy link
Member

It has been close in favor or janephp/janephp#768 ; which is still open 🤞

@damienalexandre damienalexandre mentioned this pull request Jan 2, 2024
@damienalexandre
Copy link
Member

I'm currently looking at this PR as JanePHP is now compatible with SF7.

@damienalexandre damienalexandre merged commit a29c613 into jolicode:master Jan 31, 2024
10 checks passed
@damienalexandre
Copy link
Member

Thanks a lot for your contribution! A release will be done today 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants