Update to Symfony 7 #6
Conversation
There was a problem hiding this comment.
Thank your for the PR, like you said there was no reason to keep our app in Sf6.3
However, we would like to keep using docker on this repository (as explained in this #5 (comment)), do you mind reverting this change before we can merge the upgrade ?
|
done. BTW, we could bump postgres to version 16, but also not necessary. |
.gitignore
Outdated
| ###< symfony/asset-mapper ### | ||
|
|
||
| messages.db |
There was a problem hiding this comment.
💣 chore: This should be removed now 😄
templates/base.html.twig
Outdated
| {% endblock %} | ||
|
|
||
| {% block javascripts %} | ||
| {{ importmap() }} | ||
| {% block importmap %}{{ importmap('app') }}{% endblock %} |
There was a problem hiding this comment.
🤓 nitpick: We need to run symfony console importmap:install for this to work now, could you add it to the readme (or maybe add it to the composer scripts)?
There was a problem hiding this comment.
It'd be better in composer.json scripts, yes?
I'm away from my computer, back on Wednesday, I'll do both of these then.
There was a problem hiding this comment.
I think so too
And sure no problem, there's really no rush ^^
|
I am going to close here for now due to the lack of feedback. Please let us know when you have more information and we can consider to reopen. |
|
I'll make those tweaks now. |
templates/base.html.twig
Outdated
| {% endblock %} | ||
|
|
||
| {% block javascripts %} | ||
| {{ importmap() }} | ||
| {% block importmap %}{{ importmap('app') }}{% endblock %} |
|
Done! |
|
Thanks again! |
Fix #3
Using Symfony 7 and sqlite database by default, for an easier DX experience.