Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add troubleshooting information #1023

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

koutcher
Copy link
Collaborator

No description provided.

@koutcher koutcher force-pushed the troubleshooting branch 2 times, most recently from 21f389f to 2ce85fe Compare October 14, 2020 17:22
@koutcher koutcher force-pushed the troubleshooting branch 3 times, most recently from 9be7239 to f11795b Compare December 21, 2020 17:33
Copy link
Owner

@jonas jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't know if it would make sense to link to this page from the README's bug reporting section.


See ESCDELAY environment variable in ncurses(3x) to reduce the one
second delay after pressing the escape key. Nowadays,
`export ESCDELAY=100` should be more than enough.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL 🤩

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I don't know if it would make sense to link to this page from the README's bug reporting section.

Good idea. Is this appropriate ?

 Bugs and Feature Requests
 -------------------------
+Please check out the
+https://github.com/jonas/tig/blob/master/TROUBLESHOOTING.adoc[troubleshooting guide]
+if you are experiencing issues with Tig.
+
 Bugs and feature requests can be reported using the

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, or we could also add it to book.md to make it part of the documentation site and link to it "relatively" using

link:TROUBLESHOOTING.{docext}[troubleshooting guide]

I can do that if you prefer in a future PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed my current state to the PR, I'll be happy if you want to take the lead on it. Edit at your convenience.

accented characters will be distorted.

To check that your locale is present in the list of available locales,
use `locale -a | grep "$LANG"`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get

$ locale -a
C
en_US.utf8
POSIX
$ echo $LANG
en_US.UTF-8

and I think it works fine, so I guess

Suggested change
use `locale -a | grep "$LANG"`.
use `locale -a | grep -i "$LANG"`.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting, looks like utf8 is a Linux oddity. -i won't help because of the missing hyphen. So I'd rather reword to:

-To check that your locale is present in the list of available locales,
-use `locale -a | grep "$LANG"`.
+Use `locale -a` to check if your `LANG` variable is present in the
+list of available locales (on Linux, you may find that `UTF-8` has
+been substituted for `utf8` but they are equivalent).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, thanks!
systemd's localectl list-locales uses en_US.UTF-8, but of course that's not available elsewhere.

Comment on lines 69 to 70
Note that the ability to set the `LANG` variable to values such as
`en_DE` with KDE does not infer their validity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note that the ability to set the `LANG` variable to values such as
`en_DE` with KDE does not infer their validity.
Note that the ability to set the `LANG` variable to values such as
`en_DE` with KDE does not imply their validity.

Comment on lines 42 to 43
Some OS (e.g. OS X 10.11) are shipping with an incomplete terminfo
description for screen resulting, for example, in diff-highlight option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Some OS (e.g. OS X 10.11) are shipping with an incomplete terminfo
description for screen resulting, for example, in diff-highlight option
Some OS (e.g. OS X 10.11) are shipping with an incomplete terminfo
description for screen resulting, for example, in the diff-highlight option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants