Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and update tools/aspell.dict #1303

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kianmeng
Copy link

@kianmeng kianmeng commented Nov 4, 2023

Found via make spell-check

NEWS.adoc Outdated
@@ -122,7 +122,7 @@ Bug fixes:
- Reset view->parent when main view is promoted.
- Fix segfault when pressing Enter in a child main view.
- Restore lazy navigation.
- Format time_t values portably and fix other values too. (#1084, #1085)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was OK: https://en.wiktionary.org/wiki/portably "In a portable manner"

@kianmeng kianmeng requested a review from jwilk December 27, 2023 09:51
@HaeyoonJo
Copy link

@kianmeng , good catch. IMHO, when we open PR, you need to commit in a single commit. See if this might be helpful in the following Organizing PRs and Commits document

Found via `make spell-check`
@kianmeng kianmeng force-pushed the fix-typos-and-update-aspell-dict branch from f754962 to 95444e9 Compare April 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants