tigrc: use color15 for cursor by default (bright white) #870
Conversation
"bold" does not necessarily mean "bright", and default white is hardly visible on green (using solarized colors myself). Ref: kovidgoyal/kitty#197
|
Yes, agree with you to change chocolate. Can you include it in your PR ? |
|
Ok. |
|
color15 is not necessarily the brightest white you have, it only depends on your colorscheme right? Mine for example:
|
|
@ThomasHaddad |
|
yeah sorry, my colorscheme was apparently completely broken from the start,
realized that after i did my comment here :D
…On Mon, Oct 8, 2018 at 5:44 PM Daniel Hahler ***@***.***> wrote:
@ThomasHaddad <https://github.com/ThomasHaddad>
Is that a base16 based scheme?
Anyway, color15 is at least as bright as color07 for you (the same?), and
we cannot assume people have more that 16 colors.
(I have a base16 based scheme, and color21 is dark black for me (in the
light variant))
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#870 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ADiFLAm0ShGtyd3uBd9eYPsriT6kaGkLks5ui3LggaJpZM4W7TB_>
.
--
*Thomas Haddad*
Développeur @WTTJ
welcometothejungle.co <https://www.welcometothejungle.co/>
welcomekit.co <https://www.welcomekit.co/>
| t. 06 33 26 54 49
| e. shawarma@wttj.co
| a. 11bis rue Bachaumont, 75002 Paris
|
| @@ -365,7 +365,7 @@ color " Acked-by" yellow default | |||
| color " Tested-by" yellow default | |||
| color " Reviewed-by" yellow default | |||
| color default default default normal | |||
| color cursor white green bold | |||
| color cursor color15 green bold | |||
There was a problem hiding this comment.
I'd prefer to use the ANSI color names in the default configuration. These days I am using white on red, inspired by Mutt if I remember correctly, would that be acceptable?
There was a problem hiding this comment.
ANSI color names
That is only 0-7 then?
white on red
Does not look good for me:
"bold" does not necessarily mean "bright", and default white is hardly
visible on green (using solarized colors myself).
Ref: kovidgoyal/kitty#197
Could also be changed in https://github.com/blueyed/tig/blob/4e03fe46a9cc48500abc9e70a54d4d734ab335ce/contrib/chocolate.theme.tigrc#L8 maybe. /cc @edi9999