Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Ignore and ignore-postfix #128

Closed
wants to merge 4 commits into from

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Mar 14, 2019

Fixes #114 #101

@codecov
Copy link

codecov bot commented Mar 14, 2019

Codecov Report

Merging #128 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #128   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         379    376    -3     
  Branches      165    164    -1     
=====================================
- Hits          379    376    -3
Impacted Files Coverage Δ
src/noLetRule.ts 100% <ø> (ø) ⬆️
src/readonlyKeywordRule.ts 100% <100%> (ø) ⬆️
src/noObjectMutationRule.ts 100% <100%> (ø) ⬆️
src/readonlyArrayRule.ts 100% <100%> (ø) ⬆️
src/noExpressionStatementRule.ts 100% <100%> (ø) ⬆️
src/noArrayMutationRule.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 645aff5...27e9562. Read the comment docs.

@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Mar 14, 2019

Possibly a breaking change at the moment as ignore-prefix has been rewritten. More testing is probably needed.

@RebeccaStevens

This comment has been minimized.

@RebeccaStevens RebeccaStevens force-pushed the feature/ignore-exact-and-postfix branch from 607a3aa to 56bb35e Compare May 13, 2019 05:46
@RebeccaStevens
Copy link
Collaborator Author

Closing in favor of #137

@RebeccaStevens RebeccaStevens deleted the feature/ignore-exact-and-postfix branch May 14, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore-precise
1 participant