Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a static confirm method #86

Merged
merged 6 commits into from
Jan 19, 2024

Conversation

liaokaime
Copy link
Contributor

No description provided.

@jonatanklosko
Copy link
Owner

Also please run npm run format :)

liaokaime and others added 3 commits January 19, 2024 13:56
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
Co-authored-by: Jonatan Kłosko <jonatanklosko@gmail.com>
@liaokaime
Copy link
Contributor Author

Also please run npm run format :)

I'm not familiar with github pr, this is my first time using it. In order to format, do I need to create pr again?

@jonatanklosko
Copy link
Owner

jonatanklosko commented Jan 19, 2024

@liaokaime no need for a separate PR, you can just run npm run format locally, commit and push. (You also want to git pull first to get the changes applied via GitHub UI above :))

@jonatanklosko jonatanklosko merged commit ab76325 into jonatanklosko:master Jan 19, 2024
2 checks passed
@jonatanklosko
Copy link
Owner

Published in v3.0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants