Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flavor support? #160

Closed
EinatK opened this issue Apr 2, 2021 · 20 comments
Closed

Flavor support? #160

EinatK opened this issue Apr 2, 2021 · 20 comments
Labels
feature request New feature or request

Comments

@EinatK
Copy link

EinatK commented Apr 2, 2021

Do you have flavor support?
Expected behavior similar to the launcher icons where I name different files and run the command with a custom file name.
I tried that here but failed because it couldn't find the flutter_native_splash section.
Is there another way to do it?

@jonbhanson jonbhanson added the feature request New feature or request label Apr 8, 2021
@jonbhanson
Copy link
Owner

@EinatK @pablodenadai @Rameshv @r8 @raymondddenny what platform(s) are you looking for flavor support?

@billowapp
Copy link

Plus one here, we're looking to flavor Android and iOS only at this point.

@EinatK
Copy link
Author

EinatK commented May 11, 2021

android & iOS

@jamesmoore255
Copy link

Any update on this?

@jonbhanson
Copy link
Owner

I plan on implementing this as time permits. Of course, PRs are always welcome if someone needs this soon.

@lyledean1
Copy link
Contributor

I've done a PR for this #180 @jonbhanson

@jonbhanson
Copy link
Owner

Thanks for your contribution, @lyledean1, I appreciate it! However, I am not sure that the PR you contributed will provide what the users are looking for. Although your PR allows users to select different input configurations, it does not redirect the outputs accordingly. In Android, for example, the image files for splash screens of different flavors will reside in different directories. This plugin needs to adjust for the different paths of each flavor. flutter_launcher_icons gives a good example of flavor support. I have not taken the time to investigate how iOS would implement flavor support, but I assume it is something similar.

@chainchelliah
Copy link

I also looking for this. PR got merged? Would be really helpful if it goes live.
Thanks.

@jonbhanson
Copy link
Owner

@chainchelliah the PR was merged and is live, but it only added the ability to select the config file with a command line argument.

@mellowcello77
Copy link

mellowcello77 commented Aug 2, 2021

I have spent 3 days trying to implement a splash for an iOS flavor, looks like the LaunchScreen.storyboard is compulsory for iOS now. The problem I find is that you are limited to one storyboard per target in Xcode. Does anyone have suggestions, I am imagining that a target is needed for each launchscreen, not just a scheme setup change as with the AppIcon settings as it is now.

For schemes only, you can change the "Asset Catalog Launch Image Set Name" in build settings, but this is deprecated now, it would have been an easier solution but I understand why its deprecated. I cant even get another target in iOS to launch my app. To build a launchimage package to support flavors sounds like a challenge. Does anyone have any ideas?

Cheers

@mellowcello77
Copy link

I did some more searching and found this to be useful - https://stackoverflow.com/a/66165654/11865941

@ghost
Copy link

ghost commented Dec 20, 2021

To achieve that we need for each target a info.plist (copy the original one and dupplicate for each target). Despite of launch icon, xcode use the same launchScreen for each target. so we need a specifiq plist to select the right one.

@elhe26
Copy link

elhe26 commented Jan 19, 2022

@jonbhanson, any updates? Thanks for the awesome package.

@qusaieilouti99
Copy link

@jonbhanson do you have plans to add this feature soon? Thanks.

@jonbhanson
Copy link
Owner

I don't have any plans to add this feature, but PRs are always welcome.

@jonbhanson
Copy link
Owner

jonbhanson commented May 15, 2022

Flavor support has been added in the latest version, which I will push soon. Thanks Vladimir for PR #316!

@CodeDoctorDE
Copy link

Can we open another issue for tracking Windows, Linux and Web support?

@jonbhanson
Copy link
Owner

Can we open another issue for tracking Windows, Linux and Web support?

Sure, feel free.

@CodeDoctorDE
Copy link

One issue or per platform?

@jonbhanson
Copy link
Owner

I think one issue should be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants