Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Command Line Path To Config File #180

Merged
merged 4 commits into from Jun 9, 2021

Conversation

lyledean1
Copy link
Contributor

  • Pass "--path=path/to/file.yaml" , i.e
flutter pub run flutter_native_splash:create --path=path/to/file.yaml
  • If no path specified, still goes to current defaults
  • Used args.dart as a simple way to parse args to configFile function
  • Feature Request on Flavor support? #160

Tested with branch by updating pubspec.yaml to

  flutter_native_splash:
    git: 
      url: https://github.com/lyledean1/flutter_native_splash
      ref: add-flavour

@lyledean1 lyledean1 mentioned this pull request Jun 8, 2021
@lyledean1
Copy link
Contributor Author

@jonbhanson , I will move the discussion here since it doesn't meet the requirements for the flavor feature.

Specifying a custom file path is something I currently require, so if I updated the readme to reflect this would the PR in its current state be enough to merge?

Also I could rename the "path" to "input-path" so if a flavor feature is added an output path could be added to redirect the inputs

@jonbhanson
Copy link
Owner

@lyledean1 yes, I think that would be fine. Actually, you can leave the path parameter as it is, and when the flavor feature is implemented, it can use a flavor parameter.

@lyledean1
Copy link
Contributor Author

@lyledean1 yes, I think that would be fine. Actually, you can leave the path parameter as it is, and when the flavor feature is implemented, it can use a flavor parameter.

Thanks! I've updated the readme @jonbhanson 👍

@lyledean1 lyledean1 changed the title Add Flavor Support Add Command Line Path To Config File Jun 8, 2021
@jonbhanson jonbhanson merged commit 5db4628 into jonbhanson:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants