Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables property to template frontmatter #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ezhikov
Copy link

@ezhikov ezhikov commented Oct 1, 2018

Hello.

So, my proposed solution to #61 is to add property variables to frontmatter. Other arguments have priority over variables. One thing that I'm uncertain with, if variables should be calculated depending on other variables.

If my solution satisfies you, I'll add relative section to docs and tests if you'llguide me on how to properly test this feature.

Copy link
Contributor

@epszaw epszaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are must be some tests for that functionality 🤔

@jondot
Copy link
Owner

jondot commented Dec 6, 2018

@ezhikov any possibility to add tests? LMK if you need help with understanding how testing works here

@ezhikov
Copy link
Author

ezhikov commented Dec 6, 2018

I think I do need guidance with tests.

@epszaw
Copy link
Contributor

epszaw commented Dec 7, 2018

@ezhikov it's very simple. Look at other test a try to do the same.
If you don't have any experience with unit testing and test tools, I highly recommend to read jest docs. This framework provide the most of important testing conceptions and you can learn really a lot of cool things 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants