Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update index.js #242

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.js #242

wants to merge 1 commit into from

Conversation

bonm
Copy link

@bonm bonm commented Dec 18, 2017 •
edited

Usefull fix for user parametrs
example
<!-- build:js /js/all.js?rev=1234 -->

@bonm
Update index.js
ad578bb 
Usefull fix for user parametrs
example
<!-- build:js /js/all.js?rev=1234 -->
@coveralls
Copy link

coveralls commented Dec 18, 2017 •
edited

Coverage Status

Coverage increased (+0.01%) to 98.16% when pulling ad578bb on bonm:patch-1 into c138487 on jonkemp:master.

@jonkemp
Copy link
Owner

jonkemp commented Dec 18, 2017

@bonm I want to make sure I fully understand. This change just removes the url parameters from the path before passing it on?

@bonm
Copy link
Author

bonm commented Dec 19, 2017

@jonkemp yes. file can't create with param at file system

...
<head>
<!-- build:js /js/all.js?rev=@@hash -->
<script type="text/javascript" 
...
<!-- endbuild -->

</head>

gulp build
...
[13:54:23] Error: ENOENT: no such file or directory, open 'D:\project\newApp\ru\js\all_m.js?rev=@@hash'
    at Error (native)
stream.js:74
      throw er; // Unhandled stream error in pipe.
      ^

@jonkemp
Copy link
Owner

jonkemp commented Dec 19, 2017 •
edited

Could you add a test for this?

@jonkemp
Copy link
Owner

jonkemp commented Dec 19, 2017

Also, why would you add a parameter like that to throw it away? I think most people use something like this plugin:

https://github.com/sindresorhus/gulp-rev

@bonm
Copy link
Author

bonm commented Dec 26, 2017

I use https://github.com/bustardcelly/gulp-rev-append

@bonm
Copy link
Author

bonm commented Dec 26, 2017

@jonkemp

Could you add a test for this?

Yes, i try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bonm @coveralls @jonkemp