Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature]: Suggestions #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[New Feature]: Suggestions #15

wants to merge 1 commit into from

Conversation

sricharankrishnan
Copy link

  • introduced 'Check Is Array' in the module.exports section to make sure that we receive an array
  • using pre built 'Array.forEach' to iterate over the first array
  • using pre build 'Array.findIndex' to fetch the index for the item to be check for in the diff array

@sricharankrishnan
[New Feature]: Suggestions
9f873e5 
- introduced 'Check Is Array' in the module.exports section to make sure that we receive an array
- using pre built 'Array.forEach' to iterate over the first array
- using pre build 'Array.findIndex' to fetch the index for the item to be check for in the diff array
@sricharankrishnan
Copy link
Author

Hello Jon.

Here is another suggestion from my side on how this could be redone. Let me know your thoughts on this.
Cheers!

@ChocolateLoverRaj
Copy link

  • introduced 'Check Is Array' in the module.exports section to make sure that we receive an array

I don't think this is worth it because whatever code is calling arr-diff should make sure to input arrays. This would slightly slow down performance when it is used correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sricharankrishnan @ChocolateLoverRaj