Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn Project into Typescript PR #172

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Conversation

jonycheung
Copy link
Owner

@jonycheung jonycheung commented May 6, 2024

Rewrite to TS

Copy link

what-the-diff bot commented May 6, 2024

PR Summary

  • Javascript watching disabled in sample configuration
    The sample configuration file (less-watch-compiler.sample.config.json) was modified to no longer support monitoring changes in Javascript files.

  • Main application entry point changed
    The principal entry point for this project, specified in package.json, has been changed from 'dist/less-watch-compiler.js' to the more standard 'dist/main.js'.

  • Build process update
    The script that handles project building, referred to as build in package.json, has been updated. Previously, this script was using Babel, but it has been revised to now use Typescript.

  • Files addition and deletion for better structure
    Certain non-essential JavaScript files were deleted, and their corresponding TypeScript files were created. These include src/lib/Options.ts, src/lib/Utils.ts, and several others. This was done to convert the existing JavaScript codebase to TypeScript.

  • Enhanced file watching module
    New TypeScript files, like lessWatchCompilerUtils.cjs.js and lessWatchCompilerUtils.ts, were added to improve file watching capabilities. These components help keep track of changes in the project files and expedite necessary updates.

  • Watchscript main script added
    A new TypeScript file src/main.ts was added. This script watches folders for changes and compiles LESS CSS files into CSS, thereby automatically reflecting styling changes made in LESS files without manual compilation.

  • New tests added
    To ensure the integrity of the changes made in this PR, new test files like test/Utils.js and test/filesearch.js were added. These files include various test cases for the utility and file search modules, respectively.

  • Configuration settings and CLI command updated
    Updates were made to test/less-watch-compiler.config.json and test/less-watch-compiler.js to modify the configuration settings for the less-watch-compiler and the command line interface (CLI).

  • Updated module imports and test cases
    The test/lessWatchCompilerUtils.js file was modified to update the imports of lessWatchCompilerUtils and sh modules.

  • Compiler configuration added
    A new file tsconfig.json was added, which specifies compiler options for the Typescript.

@jonycheung jonycheung changed the title Turn into Typescript PR Turn Project into Typescript PR May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant