Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test sauce labs tests #214

Merged
merged 13 commits into from
Jan 19, 2023
Merged

test sauce labs tests #214

merged 13 commits into from
Jan 19, 2023

Conversation

dgrammatiko
Copy link
Collaborator

@dgrammatiko dgrammatiko commented Nov 22, 2022

DO NOT MERGE THIS!!!!!

@dgrammatiko
Copy link
Collaborator Author

@wilsonge
Copy link
Contributor

wilsonge commented Jan 4, 2023

I've had to directly commit the workflow stuff here because the tests wouldn't run anymore because of the higher node version required. At least the tests run in chrome again now which they didn't before.

@dgrammatiko
Copy link
Collaborator Author

dgrammatiko commented Jan 4, 2023

Maybe I could try to use a patch (eg https://www.npmjs.com/package/patch-package) and get the Saucelabs tunnel in a working state. I'll have a look when I get home on both these PRs. The delay on both is due to the broken remote tests...

@dgrammatiko
Copy link
Collaborator Author

@wilsonge so I forked the karma-sauce-launcher and applied the PR and the remote tests are green again. Let me know if that's ok as a temp solution, till the upstream repo merges the karma-runner/karma-sauce-launcher#278

@wilsonge
Copy link
Contributor

wilsonge commented Jan 19, 2023

karma-runner/karma-sauce-launcher#275 (comment) Are we able to stay with the original and use this workaround?

If not your fork is fine. We just need to document somewhere for the future in case they are able to magically deploy things.

@dgrammatiko
Copy link
Collaborator Author

@wilsonge applied the override, so no more forks. Merge it and let's see if it actually works

@wilsonge
Copy link
Contributor

Looks good. Am I merging this one or you going to push to #215 this new part?

@dgrammatiko
Copy link
Collaborator Author

Merge this one, I have to review the other again (it's been a while and some pkgs might need another update)

@wilsonge wilsonge merged commit 0a4e6dd into master Jan 19, 2023
@wilsonge wilsonge deleted the dgrammatiko-patch-1 branch January 19, 2023 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants