Reuse buffers using a pool #95
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are various approaches to it, though:
* Have a buffer for each `Email` instance. This would make `Email` not
being thread-safe anymore.
* Have a `sync.Pool` containing `bytes.Buffer` instances. This is
probably a better approach with fewer surprises for users of this
library. Assuming that this would be a non-exported field on `Email`,
this would mean that `EMail` can't be instantiated using `Email{...}`
anymore, which might not be what we want? At least it'll be a
compilation error, though. Workaround for this issue would be to use
a `sync.Once` to make sure to instantiate the pool.
Reduces memory allocation and fixes a TODO.
JensRantil
commented
Sep 13, 2021
| @@ -201,7 +236,7 @@ func parseMIMEParts(hs textproto.MIMEHeader, b io.Reader) ([]*part, error) { | |||
| return ps, err | |||
| } | |||
| if strings.HasPrefix(subct, "multipart/") { | |||
| sps, err := parseMIMEParts(p.Header, p) | |||
| sps, err := parseMIMEParts(p.Header, p, bufPool) | |||
| if err != nil { | |||
| return ps, err | |||
There was a problem hiding this comment.
Maybe also hand back when returning?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a TODO. Worth it?