Rename spin animation #1333
Merged
Rename spin animation #1333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spin animation defined by selectr collides with the spin animation defined by tailwind. It overrides the animation and causes the spinning elements to spin offcenter. By renaming it we kinda namespace it and prevent a collision.
|
Thanks, makes sense. Maybe a good idea if tailwind would also use prefixes for their class names 😁 . I remember Bootstrap also giving these kind of conflicts due to too generic class names. |
|
Hey! Thanks for merging. Actually, they did for v2 (tailwindlabs/tailwindcss#2621), but v1.9.6 is unprefixed and if you need IE11 support you can't update. |
|
Ahh that's good to hear! |
|
Fixed now in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spin animation defined by selectr collides with the spin
animation defined by tailwind. It overrides the animation and causes
the spinning elements to spin offcenter. By renaming it we kinda
namespace it and prevent a collision.
Definition of tailwind spin animation