perf(common): make NgLocalization token tree-shakable (angular#45118)

This commit updates the `NgLocalization` token to become tree-shakable (vs using a direct reference to that token in the `providers` section of the `CommonModule`). The `NgLocalization` token is used for apps that use i18n and for other apps it would be excluded from the bundle. PR Close angular#45118
josmar-crwdstffng · Apr 8, 2022 · fab2492 · fab2492
1 parent 61283d8
commit fab2492
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 110 deletions.
diff --git a/goldens/size-tracking/aio-payloads.json b/goldens/size-tracking/aio-payloads.json
@@ -15,7 +15,7 @@
     "master": {
       "uncompressed": {
         "runtime": 4343,
-        "main": 450179,
+        "main": 449672,
         "polyfills": 33869,
         "styles": 70416,
         "light-theme": 77582,

diff --git a/goldens/size-tracking/integration-payloads.json b/goldens/size-tracking/integration-payloads.json
@@ -3,7 +3,7 @@
     "master": {
       "uncompressed": {
         "runtime": 1083,
-        "main": 126218,
+        "main": 124515,
         "polyfills": 33824
       }
     }
@@ -42,7 +42,7 @@
     "master": {
       "uncompressed": {
         "runtime": 2835,
-        "main": 233348,
+        "main": 232814,
         "polyfills": 33842,
         "src_app_lazy_lazy_module_ts": 795
       }
@@ -52,7 +52,7 @@
     "master": {
       "uncompressed": {
         "runtime": 1063,
-        "main": 158556,
+        "main": 156042,
         "polyfills": 33804
       }
     }
@@ -61,7 +61,7 @@
     "master": {
       "uncompressed": {
         "runtime": 1070,
-        "main": 158300,
+        "main": 155753,
         "polyfills": 33814
       }
     }

diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -116,9 +116,6 @@
   {
     "name": "CommonModule"
   },
-  {
-    "name": "Compiler"
-  },
   {
     "name": "ComponentFactory"
   },
@@ -242,18 +239,12 @@
   {
     "name": "LEAVE_TOKEN_REGEX"
   },
-  {
-    "name": "LOCALE_DATA"
-  },
   {
     "name": "LOCALE_ID2"
   },
   {
     "name": "LifecycleHooksFeature"
   },
-  {
-    "name": "LocaleDataIndex"
-  },
   {
     "name": "MODIFIER_KEYS"
   },
@@ -326,15 +317,6 @@
   {
     "name": "NULL_REMOVED_QUERIED_STATE"
   },
-  {
-    "name": "NgLocaleLocalization"
-  },
-  {
-    "name": "NgLocalization"
-  },
-  {
-    "name": "NgModuleFactory2"
-  },
   {
     "name": "NgModuleRef"
   },
@@ -377,9 +359,6 @@
   {
     "name": "PlatformRef"
   },
-  {
-    "name": "Plural"
-  },
   {
     "name": "R3Injector"
   },
@@ -404,9 +383,6 @@
   {
     "name": "RuntimeError"
   },
-  {
-    "name": "SCHEDULER"
-  },
   {
     "name": "SELF_TOKEN_REGEX"
   },
@@ -656,6 +632,9 @@
   {
     "name": "collectNativeNodes"
   },
+  {
+    "name": "compileNgModuleFactory"
+  },
   {
     "name": "computeStaticStyling"
   },
@@ -857,9 +836,6 @@
   {
     "name": "getLViewParent"
   },
-  {
-    "name": "getLocaleData"
-  },
   {
     "name": "getNativeByTNode"
   },
@@ -1088,9 +1064,6 @@
   {
     "name": "listenOnPlayer"
   },
-  {
-    "name": "locale_en_default"
-  },
   {
     "name": "lookupTokenUsingModuleInjector"
   },
@@ -1355,9 +1328,6 @@
   {
     "name": "transition"
   },
-  {
-    "name": "u"
-  },
   {
     "name": "uniqueIdCounter"
   },
@@ -1406,6 +1376,9 @@
   {
     "name": "ɵɵelement"
   },
+  {
+    "name": "ɵɵelementEnd"
+  },
   {
     "name": "ɵɵelementStart"
   },

diff --git a/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json b/packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json
@@ -224,18 +224,12 @@
   {
     "name": "KeyEventsPlugin"
   },
-  {
-    "name": "LOCALE_DATA"
-  },
   {
     "name": "LOCALE_ID2"
   },
   {
     "name": "LifecycleHooksFeature"
   },
-  {
-    "name": "LocaleDataIndex"
-  },
   {
     "name": "MODIFIER_KEYS"
   },
@@ -329,12 +323,6 @@
   {
     "name": "NgForOf"
   },
-  {
-    "name": "NgLocaleLocalization"
-  },
-  {
-    "name": "NgLocalization"
-  },
   {
     "name": "NgModuleFactory2"
   },
@@ -377,9 +365,6 @@
   {
     "name": "PlatformRef"
   },
-  {
-    "name": "Plural"
-  },
   {
     "name": "R3Injector"
   },
@@ -911,9 +896,6 @@
   {
     "name": "getLViewParent"
   },
-  {
-    "name": "getLocaleData"
-  },
   {
     "name": "getNativeByTNode"
   },
@@ -1205,9 +1187,6 @@
   {
     "name": "leaveViewLight"
   },
-  {
-    "name": "locale_en_default"
-  },
   {
     "name": "lookupTokenUsingModuleInjector"
   },
@@ -1517,9 +1496,6 @@
   {
     "name": "trackByIdentity"
   },
-  {
-    "name": "u"
-  },
   {
     "name": "uniqueIdCounter"
   },

diff --git a/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json b/packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json
@@ -212,18 +212,12 @@
   {
     "name": "KeyEventsPlugin"
   },
-  {
-    "name": "LOCALE_DATA"
-  },
   {
     "name": "LOCALE_ID2"
   },
   {
     "name": "LifecycleHooksFeature"
   },
-  {
-    "name": "LocaleDataIndex"
-  },
   {
     "name": "MODIFIER_KEYS"
   },
@@ -317,12 +311,6 @@
   {
     "name": "NgForm"
   },
-  {
-    "name": "NgLocaleLocalization"
-  },
-  {
-    "name": "NgLocalization"
-  },
   {
     "name": "NgModel"
   },
@@ -371,9 +359,6 @@
   {
     "name": "PlatformRef"
   },
-  {
-    "name": "Plural"
-  },
   {
     "name": "R3Injector"
   },
@@ -875,9 +860,6 @@
   {
     "name": "getLViewParent"
   },
-  {
-    "name": "getLocaleData"
-  },
   {
     "name": "getNativeByTNode"
   },
@@ -1166,9 +1148,6 @@
   {
     "name": "leaveViewLight"
   },
-  {
-    "name": "locale_en_default"
-  },
   {
     "name": "lookupTokenUsingModuleInjector"
   },
@@ -1496,9 +1475,6 @@
   {
     "name": "trackByIdentity"
   },
-  {
-    "name": "u"
-  },
   {
     "name": "uniqueIdCounter"
   },

diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -251,9 +251,6 @@
   {
     "name": "KeyEventsPlugin"
   },
-  {
-    "name": "LOCALE_DATA"
-  },
   {
     "name": "LOCALE_ID2"
   },
@@ -275,9 +272,6 @@
   {
     "name": "LoadedRouterConfig"
   },
-  {
-    "name": "LocaleDataIndex"
-  },
   {
     "name": "Location"
   },
@@ -371,12 +365,6 @@
   {
     "name": "NavigationStart"
   },
-  {
-    "name": "NgLocaleLocalization"
-  },
-  {
-    "name": "NgLocalization"
-  },
   {
     "name": "NgModuleFactory"
   },
@@ -443,9 +431,6 @@
   {
     "name": "PlatformRef"
   },
-  {
-    "name": "Plural"
-  },
   {
     "name": "Position"
   },
@@ -1223,9 +1208,6 @@
   {
     "name": "getLViewParent"
   },
-  {
-    "name": "getLocaleData"
-  },
   {
     "name": "getNativeByTNode"
   },
@@ -1520,9 +1502,6 @@
   {
     "name": "leaveViewLight"
   },
-  {
-    "name": "locale_en_default"
-  },
   {
     "name": "locateDirectiveOrProvider"
   },
@@ -1895,9 +1874,6 @@
   {
     "name": "tree"
   },
-  {
-    "name": "u"
-  },
   {
     "name": "uniqueIdCounter"
   },