-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for static analysis: fix types #18
base: master
Are you sure you want to change the base?
Conversation
@@ -62,7 +62,7 @@ protected function insertModel() | |||
*/ | |||
protected function persistDefaultFields() | |||
{ | |||
$this->persistModel(); | |||
return $this->persistModel(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛
@@ -152,7 +152,7 @@ public function delete() | |||
|
|||
wp_delete_post($this->id); | |||
|
|||
parent::delete(); | |||
return parent::delete(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐛
BTW Relative class names in PHPDoc blocks are confusing. |
@jplhomer PHPStan will occupy you for few hours if you feel its huge Benefit. |
I think I do not understand this project. |
Purpose
@jplhomer Preparations for static analysis.
Level of Changes
Tests
@phpstan config included
Docs
no need