Set new directory mode after copying files (MacOS fix)

See issue 599

lib/copy/__tests__/copy-readonly-dir.test.js

@@ -0,0 +1,46 @@
+'use strict'
+
+// relevant: https://github.com/jprichardson/node-fs-extra/issues/599
+
+const fs = require(process.cwd())
+const os = require('os')
+const fse = require('../../')
+const path = require('path')
+const assert = require('assert')
+const klawSync = require('klaw-sync')
+
+/* global afterEach, beforeEach, describe, it */
+
+let TEST_DIR = ''
+
+const FILES = [
+  path.join('dir1', 'file1.txt'),
+  path.join('dir1', 'dir2', 'file2.txt'),
+  path.join('dir1', 'dir2', 'dir3', 'file3.txt')
+]
+
+describe('+ copy() - copy a readonly directory with content', () => {
+  beforeEach(done => {
+    TEST_DIR = path.join(os.tmpdir(), 'test', 'fs-extra', 'copy-readonly-dir')
+    fse.emptyDir(TEST_DIR, done)
+  })
+
+  afterEach(done => {
+    klawSync(TEST_DIR).forEach(data => fs.chmodSync(data.path, 0o777))
+    fse.remove(TEST_DIR, done)
+  })
+
+  describe('> when src is readonly directory with content', () => {
+    it('should copy successfully', done => {
+      FILES.forEach(file => {
+        fs.outputFileSync(path.join(TEST_DIR, file), file)
+      })
+      klawSync(TEST_DIR).forEach(data => fs.chmodSync(data.path, data.stats.isDirectory() ? 0o555 : 0o444))
+
+      fse.copy(path.join(TEST_DIR, 'dir1'), path.join(TEST_DIR, 'target'), err => {
+        assert.ifError(err)
+        done()
+      })
+    })
+  })
+})

lib/copy/copy.js

@@ -149,11 +149,11 @@ function mayCopyDir (src, dest, opts, cb) {
 }
 
 function mkDirAndCopy (srcStat, src, dest, opts, cb) {
-  fs.mkdir(dest, srcStat.mode, err => {
+  fs.mkdir(dest, err => {
     if (err) return cb(err)
-    fs.chmod(dest, srcStat.mode, err => {
+    copyDir(src, dest, opts, err => {
       if (err) return cb(err)
-      return copyDir(src, dest, opts, cb)
+      return fs.chmod(dest, srcStat.mode, cb)
     })
   })
 }