Fix logic error in stats comparison

jprichardson · Jun 1, 2019 · bea4a39 · bea4a39
1 parent c879654
commit bea4a39
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/lib/util/stat.js b/lib/util/stat.js
@@ -155,15 +155,14 @@ function checkParentPathsSync (src, srcStat, dest, funcName) {
 
 function areApparentlyIdentical (srcStat, destStat) {
   if (destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
-    if (nodeSupportsBigInt()) {
+    if (nodeSupportsBigInt() || destStat.ino < Number.MAX_SAFE_INTEGER) {
       // definitive answer
       return true
     }
     // Use additional heuristics if we can't use 'bigint'.
-    // Different 'ino' could be represented the same if they are >= Number.MAX_SAFE_INTEGER
+    // Different 'ino' could be represented the same if they are >= Number.MAX_SAFE_INTEGER
     // See issue 657
-    if (destStat.ino >= Number.MAX_SAFE_INTEGER &&
-        destStat.size === srcStat.size &&
+    if (destStat.size === srcStat.size &&
         destStat.mode === srcStat.mode &&
         destStat.nlink === srcStat.nlink &&
         destStat.atimeMs === srcStat.atimeMs &&