Merge pull request #694 from mbargiel/feature/stats-heuristics-withou…

…t-bigint Add heuristics to stats.ino comparison when bigint is not available
jprichardson · Jul 30, 2019 · e3d1ab8 · e3d1ab8
2 parents ca58cbc + 391fb73
commit e3d1ab8
Showing 1 changed file with 28 additions and 5 deletions.
diff --git a/lib/util/stat.js b/lib/util/stat.js
@@ -76,7 +76,7 @@ function checkPaths (src, dest, funcName, cb) {
   getStats(src, dest, (err, stats) => {
     if (err) return cb(err)
     const { srcStat, destStat } = stats
-    if (destStat && destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
+    if (destStat && areIdentical(srcStat, destStat)) {
       return cb(new Error('Source and destination must not be the same.'))
     }
     if (srcStat.isDirectory() && isSrcSubdir(src, dest)) {
@@ -88,7 +88,7 @@ function checkPaths (src, dest, funcName, cb) {
 
 function checkPathsSync (src, dest, funcName) {
   const { srcStat, destStat } = getStatsSync(src, dest)
-  if (destStat && destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
+  if (destStat && areIdentical(srcStat, destStat)) {
     throw new Error('Source and destination must not be the same.')
   }
   if (srcStat.isDirectory() && isSrcSubdir(src, dest)) {
@@ -111,7 +111,7 @@ function checkParentPaths (src, srcStat, dest, funcName, cb) {
         if (err.code === 'ENOENT') return cb()
         return cb(err)
       }
-      if (destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
+      if (areIdentical(srcStat, destStat)) {
         return cb(new Error(errMsg(src, dest, funcName)))
       }
       return checkParentPaths(src, srcStat, destParent, funcName, cb)
@@ -122,7 +122,7 @@ function checkParentPaths (src, srcStat, dest, funcName, cb) {
         if (err.code === 'ENOENT') return cb()
         return cb(err)
       }
-      if (destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
+      if (areIdentical(srcStat, destStat)) {
         return cb(new Error(errMsg(src, dest, funcName)))
       }
       return checkParentPaths(src, srcStat, destParent, funcName, cb)
@@ -145,12 +145,35 @@ function checkParentPathsSync (src, srcStat, dest, funcName) {
     if (err.code === 'ENOENT') return
     throw err
   }
-  if (destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
+  if (areIdentical(srcStat, destStat)) {
     throw new Error(errMsg(src, dest, funcName))
   }
   return checkParentPathsSync(src, srcStat, destParent, funcName)
 }
 
+function areIdentical (srcStat, destStat) {
+  if (destStat.ino && destStat.dev && destStat.ino === srcStat.ino && destStat.dev === srcStat.dev) {
+    if (nodeSupportsBigInt() || destStat.ino < Number.MAX_SAFE_INTEGER) {
+      // definitive answer
+      return true
+    }
+    // Use additional heuristics if we can't use 'bigint'.
+    // Different 'ino' could be represented the same if they are >= Number.MAX_SAFE_INTEGER
+    // See issue 657
+    if (destStat.size === srcStat.size &&
+        destStat.mode === srcStat.mode &&
+        destStat.nlink === srcStat.nlink &&
+        destStat.atimeMs === srcStat.atimeMs &&
+        destStat.mtimeMs === srcStat.mtimeMs &&
+        destStat.ctimeMs === srcStat.ctimeMs &&
+        destStat.birthtimeMs === srcStat.birthtimeMs) {
+      // heuristic answer
+      return true
+    }
+  }
+  return false
+}
+
 // return true if dest is a subdir of src, otherwise false.
 // It only checks the path strings.
 function isSrcSubdir (src, dest) {