Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.move should noop when source and desc are the same. #377

Closed
jdalton opened this issue Mar 3, 2017 · 3 comments
Closed

fs.move should noop when source and desc are the same. #377

jdalton opened this issue Mar 3, 2017 · 3 comments
Labels
feature-move

Comments

@jdalton
Copy link
Contributor

jdalton commented Mar 3, 2017

Since the file is already at its destination fs.move should noop. Similar to how fs.remove doesn't error if a file doesn't exist.
@RyanZim
Copy link
Collaborator

RyanZim commented Mar 3, 2017

@jdalton I agree this case should be handled. Interested in submitting a PR?

BTW, what's the current behavior?

@jdalton
Copy link
Contributor Author

jdalton commented Mar 3, 2017

Yep. I'll submit a PR. The current behavior is to throw an error (some already-exists error)

@jdalton jdalton mentioned this issue Mar 3, 2017
Merged
@jdalton
Copy link
Contributor Author

jdalton commented Mar 3, 2017

Moved to #378.

@jdalton jdalton closed this as completed Mar 3, 2017
@renovate renovate bot mentioned this issue Apr 17, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-move
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdalton @RyanZim