Don't move when source and dest paths are the same. #378
Conversation
lib/move/index.js
Outdated
| if (overwrite) { | ||
| if (path.resolve(source) === path.resolve(dest)) { | ||
| setTimeout(callback, 1) | ||
| } else if (overwrite) { |
There was a problem hiding this comment.
fs.move is async do you want it to exit early as such too (the setTimeout).
Do y'all have a pattern in place for this already?
There was a problem hiding this comment.
@jdalton what are your thoughts on setTimeout over setImmediate? It's my understanding setTimeout with an input of 1, still clamps to 15 ms.
There was a problem hiding this comment.
what are your thoughts on setTimeout over setImmediate? It's my understanding setTimeout with an input of 1, still clamps to 15 ms.
I have no strong opinions on it here since the primary goal is to just defer it a bit.
However, based on that goal setImmediate does look like a better call.
|
Before the behavior would error out, right? Should we consider this breaking? Thoughts @jdalton? |
|
It did error out. I would consider this a bug fix. (I haven't forgotten about the unit tests, just busy) |
|
What should be the correct behavior then? Since whatever that'd be, the same behavior should be applied to |
I'm asserting by the previous discussion, title, and behavior of this PR "Don't move when source and dest paths are the same." |
|
Added tests. |
|
Thank you @jdalton! |
This PR addresses #377 to avoid a move operation if the
sourceanddestpaths are the same.(I'll add tests too, just wanted to get the ball rolling)