fs.move folder report EPERM error

[fpsqdb]

• Operating System: Windows 10 1809 17763.475
• Node.js version: 7.9.0 (within electron 1.7.9)
• fs-extra version: 8.0.0

fs.move folder will cause EPERM error, it works fine if downgrade to 7.0.1.

[manidlou]

We added checking paths in v8.0.1 that stats src and dest. Seems like the running process doesn't have permissions to stat the folder! Windows is known to throw EPERM error in different situations!

I am thinking maybe we should remove path checking in move! My primary goal was to be consistent with copy as well as avoiding possible future bugs. But if we believe it is not that needed for move, I am fine removing it! We can take care of the 🐛s once they show up!

[manidlou]

Also could be because we disabled graceful-fs (#664) and switched to native fs as graceful-fs needs to be updated. Basically, graceful-fs has some improvements over native fs like handling EPERM error on windows when trying to rename a file.

[RyanZim]

Has anyone else been able to reproduce this? @fpsqdb can you write a failing test case?

[malept]

FWIW, I can reproduce this in the Electron Packager testsuite, but unfortunately since I don't personally own a Windows machine, it would be rather difficult for me to write a minimal testcase.

[manidlou]

Another thing is I am wondering if it happens outside of electron as well! Has anyone been also experiencing this in environments other than electron?

[fpsqdb]

electron-quick-start.zip

npm install

npm run start

If there are no errors, delete the dest/test folder and try again.

[malept]

The Electron Packager tests run in a Node environment, not an Electron one.

[manidlou]

Looking at the provided travis log, EPERM error comes from rename and the only thing that is changed in the internal rename function of move from fs-extra 7.0.1 to 8.0.1 is that we use native fs instead of graceful-fs temporarily (#664). My gut tells me once we switch back to graceful-fs this will be resolved. Basically, this is one of the reasons (advantages) that we use graceful-fs as a dependency so that we don't need to do extra work for cases like this here in our codebase!

[malept]

FYI, graceful-fs 4.2.0 has been released with the fs.stat() fix.

[RyanZim]

On it