Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor move / rimraf to ES6 #362

Merged
merged 2 commits into from Feb 20, 2017

Conversation

JPeer264
Copy link
Collaborator

(#355)
move:

I renamed the function from mv to move, it shouldn't be a breaking change

rimraf:

Here I put module.exports to the end of the file, as it is the same in all other files. Also I refactored one line if-statements, also with the same reason that it is the same in all other files.


I skipped copy/ncp as discussed in #360 (comment). Now I will start with the tests, unless I missed anything. I will make a pull request for each folder (copy, copy-sync, ...) if that is ok for you.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 85.434% when pulling b9d8b45 on JPeer264:feature/refactor-es6 into f831b05 on jprichardson:master.

@jprichardson jprichardson merged commit 9fc96fd into jprichardson:master Feb 20, 2017
@jprichardson
Copy link
Owner

Thanks @JPeer264!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants