Refactor tests to ES6 #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanZim
approved these changes
Feb 22, 2017
There was a problem hiding this comment.
PR overall looks good to me, I left one inline comment where shorthand could be used. If you change that, please rebase it into the correct commit. Thanks!
Travis build status hooks seem to be having trouble, the actual Travis build passed, the status hook never updated.
RyanZim
reviewed
Feb 22, 2017
| const replacer = (k, v) => { | ||
| if (v === 'JP') return 'Jon Paul' | ||
| return v | ||
| } |
There was a problem hiding this comment.
Could be shortened to:
const replacer = (k, v) => v === 'JP' ? 'Jon Paul' : vIt's up to you if you want to shorten this or not.
There was a problem hiding this comment.
That's a good one - it is updated. Thanks!
RyanZim
approved these changes
Feb 22, 2017
|
Thanks @JPeer264! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#355)
In commit 55aadcf I removed
semver, as dependency as it was just used to ignore Node v0.10.