Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to ES6 #372

Merged
merged 3 commits into from Feb 25, 2017
Merged

Refactor tests to ES6 #372

merged 3 commits into from Feb 25, 2017

Conversation

JPeer264
Copy link
Collaborator

@JPeer264 JPeer264 commented Feb 25, 2017 •
edited

Everything should be refactored to Node v4 ES6. This should close #355

EDIT:
Everything except copy/ncp as discussed in #360 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.434% when pulling 7bddeb5 on JPeer264:feature/refactor-es6 into cb24018 on jprichardson:master.

RyanZim
RyanZim approved these changes Feb 25, 2017
View reviewed changes
Copy link
Collaborator

@RyanZim RyanZim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

@jprichardson jprichardson merged commit 42656df into jprichardson:master Feb 25, 2017
@jprichardson
Copy link
Owner

Thanks @JPeer264!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanZim RyanZim RyanZim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

es6 refactoring
4 participants
@JPeer264 @coveralls @jprichardson @RyanZim