Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move() should error when src & dest are the same and src doesn't exist #415

Merged
merged 1 commit into from May 4, 2017
Merged

move() should error when src & dest are the same and src doesn't exist #415

merged 1 commit into from May 4, 2017

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented May 2, 2017 •
edited

Fixes #414; bug introduced in #378

@jprichardson What's your opinion on semver for this patch?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.925% when pulling 5bfcb64 on move-error into f26a946 on master.

@manidlou
Copy link
Collaborator

manidlou commented May 3, 2017

Thanks @RyanZim 👍

@RyanZim
Copy link
Collaborator Author

RyanZim commented May 4, 2017

@jprichardson ping?

@RyanZim RyanZim mentioned this pull request May 4, 2017
Closed
@jprichardson jprichardson merged commit 62d40b3 into master May 4, 2017
@RyanZim RyanZim deleted the move-error branch May 4, 2017 21:58
@RyanZim
Copy link
Collaborator Author

RyanZim commented May 4, 2017

@jprichardson Want this released? What semver?

@jprichardson
Copy link
Owner

@jprichardson Want this released? What semver?

yeah, 3.0.1

@renovate renovate bot mentioned this pull request Feb 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manidlou manidlou manidlou approved these changes

@jprichardson jprichardson Awaiting requested review from jprichardson

Assignees
No one assigned
Labels
bug feature-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RyanZim @coveralls @manidlou @jprichardson