Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: fs.read() & fs.write() should return objects #449

Merged
merged 2 commits into from Jul 14, 2017

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Jun 26, 2017

For forward-compat with util.promisify()

Resolves #436

Needs docs yet

Repository owner deleted a comment from coveralls Jun 26, 2017
@RyanZim RyanZim force-pushed the read-write-obj branch 2 times, most recently from 28ac447 to d3545d4 Compare June 26, 2017 19:14
Repository owner deleted a comment from coveralls Jun 26, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.174% when pulling d3545d4 on read-write-obj into 15db64f on master.

@RyanZim
Copy link
Collaborator Author

RyanZim commented Jun 26, 2017

Windows CI fails due to funky windows timestamps; unrelated to this change.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 87.174% when pulling 5a8d568 on read-write-obj into 15db64f on master.

@ghost
Copy link

ghost commented Jul 7, 2017

@RyanZim But why does the node.js v4 build pass and the v6 build fail?

@RyanZim
Copy link
Collaborator Author

RyanZim commented Jul 7, 2017

@Yamboy1 It's a 32-bit windows issue; nothing critical.

@ghost
Copy link

ghost commented Jul 7, 2017

@RyanZim It's reasons like this why I prefer to use Linux

@ghost
Copy link

ghost commented Jul 7, 2017

Windows just has too many bugs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants