Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/492 - Replace fs.link/unlink with fs.rename in fse.move #507

Closed
wants to merge 4 commits into from
Closed

bugfix/492 - Replace fs.link/unlink with fs.rename in fse.move #507

wants to merge 4 commits into from

Commits on Nov 2, 2017

  1. Replace link/unlink with rename in fse.copy 

    Add existence check first, since rename overwrites by default.
Update unit tests.
    Fawn Bertram committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    8a7aaf7 View commit details
    Browse the repository at this point in the history

  2. Remove ENOTSUP error logic 

    ENOTSUP is not an error returned by rename, nor link for that matter. No unit tests require it either.
Documentation: http://man7.org/linux/man-pages/man2/rename.2.html, http://man7.org/linux/man-pages/man2/link.2.html
    Fawn Bertram committed Nov 2, 2017
    Configuration menu
    Copy the full SHA
    52598d1 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2017

  1. remove EISDIR error check, since it does not apply

    Fawn Bertram committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    2a5a1bb View commit details
    Browse the repository at this point in the history

  2. add EISDIR check back in

    Fawn Bertram committed Nov 3, 2017
    Configuration menu
    Copy the full SHA
    09236ab View commit details
    Browse the repository at this point in the history