Rewrite copySync

[manidlou]

This is the rewrite of copySync to match copy. It should resolve #83, #198, and #464. Added corresponding tests for those issues. Also, removed the fixtures folder that was used by the copy-sync-preserve-time.test.js, instead the fixtures directory is created in the code.

Please let me know if anything doesn't look alright!

[manidlou]

IDK! it is so strange! the unit test for the case when preserveTimestamp is true, sometimes pass and sometimes doesn't! particularly on older node versions! 😕

[manidlou]

Any ideas?

[coveralls]

Coverage decreased (-0.9%) to 85.241% when pulling 5d1f2d3 on rewrite-copySync into 03fba97 on develop.

[RyanZim]

Looks good

[RyanZim]

Will look at timestamps later.

[RyanZim]

@manidlou Spent a bunch of time messing with this, can't figure it out. I'm gonna say just put a conditional in place that that flaky test gets skipped on older node versions. @jprichardson Let me know if you disagree here.

[manidlou]

@manidlou Spent a bunch of time messing with this, can't figure it out. I'm gonna say just put a conditional in place that that flaky test gets skipped on older node versions.

I agree. I played with it too, but no success! I am not sure but it seems like it is somehow related to node internals.

[coveralls]

Coverage decreased (-0.8%) to 85.364% when pulling 5bdbdc4 on rewrite-copySync into 03fba97 on develop.

[manidlou]

If looks good, I will squash this.

[manidlou]

@jprichardson do you have any concerns regarding this?

[jprichardson]

Nice work @manidlou!