Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Use internal fork of make-dir for mkdirs implementation #756

Merged
merged 7 commits into from Feb 18, 2020
Merged

BREAKING: Use internal fork of make-dir for mkdirs implementation #756

merged 7 commits into from Feb 18, 2020

Commits on Feb 14, 2020

  1. BREAKING: Use internal fork of make-dir for mkdirs implementation 

    Resolves #619

Everything should work similarly to how it did before; except that
we no longer return a file path on success (to match fs.mkdir).
Also, errors may be different.
    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    1dfee83 View commit details
    Browse the repository at this point in the history

  2. Hopefully fix Windows tests 

    - Error codes are different
- Match fs.mkdir behavior on Windows when creating root
    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    d65f9f5 View commit details
    Browse the repository at this point in the history

  3. Port sindresorhus/make-dir#24

    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    51938c2 View commit details
    Browse the repository at this point in the history

  4. Add comment for clarity

    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    53fbddf View commit details
    Browse the repository at this point in the history

  5. Use at-least-node for version sniffing

    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    29b55cb View commit details
    Browse the repository at this point in the history

  6. Consistent error codes across OSes

    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    eac8cd9 View commit details
    Browse the repository at this point in the history

  7. Allow different error codes on different Node versions

    @RyanZim
    RyanZim committed Feb 14, 2020
    Copy the full SHA
    b0d3a82 View commit details
    Browse the repository at this point in the history