Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use deprecated process.umask() #791

Merged
merged 2 commits into from Apr 24, 2020
Merged

Don't use deprecated process.umask() #791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4cd17e4
Don't use deprecated process.umask()
RyanZim Apr 23, 2020
bee95a7
Remove unneeded umask tests
RyanZim Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
80 changes: 0 additions & 80 deletions lib/mkdirs/__tests__/umask.test.js
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions lib/mkdirs/make-dir.js
View file
Open in desktop
Expand Up @@ -25,8 +25,7 @@ const checkPath = pth => {
}

const processOptions = options => {
// Must be defined here so we get fresh process.umask()
const defaults = { mode: 0o777 & (~process.umask()) }
const defaults = { mode: 0o777 }
if (typeof options === 'number') options = { mode: options }
return { ...defaults, ...options }
}
Expand Down