Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert check for fs.realpath.native (#887) #953

Merged
merged 6 commits into from Apr 16, 2022
Merged

Revert check for fs.realpath.native (#887) #953

merged 6 commits into from Apr 16, 2022

Commits on Apr 6, 2022

  1. Revert "Remove check for fs.realpath.native support, since it's every… 

    …where (#887)"

This reverts commit f4a880d.
    @lamweili
    lamweili committed Apr 6, 2022
    Copy the full SHA
    8f942de View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Added warning and fallback support for missing fs.realpath.native 

    Signed-off-by: Lam Wei Li <peteriman@mail.com>
    @lamweili
    lamweili committed Apr 9, 2022
    Copy the full SHA
    07b0b24 View commit details
    Browse the repository at this point in the history

  2. Removed NodeJS check and fs.realpath.native fallback 

    Signed-off-by: Lam Wei Li <peteriman@mail.com>
    @lamweili
    lamweili committed Apr 9, 2022
    Copy the full SHA
    d06854f View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2022

  1. Leaving original listener intact during test and better phasing for w… 

    …arning

Signed-off-by: Lam Wei Li <peteriman@mail.com>
    @lamweili
    lamweili committed Apr 10, 2022
    Copy the full SHA
    38b85a0 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2022

  1. Using done() for proper async test 

    Signed-off-by: Lam Wei Li <peteriman@mail.com>
    @lamweili
    lamweili committed Apr 11, 2022
    Copy the full SHA
    782121f View commit details
    Browse the repository at this point in the history

  2. Updated comments for clarity 

    Co-authored-by: Ryan Zimmerman <17342435+RyanZim@users.noreply.github.com>
    @lamweili @RyanZim
    lamweili and RyanZim committed Apr 11, 2022
    Copy the full SHA
    882a00f View commit details
    Browse the repository at this point in the history