Fix preserving timestamp when the move command is executing #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not clear to me why the large refactor is needed; theoretically you only need to set |
|
@RyanZim Reverted original code, that refactoring might be overengineering for now 🤔 |
RyanZim
reviewed
Mar 3, 2023
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
Co-authored-by: Ryan Zimmerman <opensrc@ryanzim.com>
|
Thank you for reviewing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue: #992.
These test files are pretty similar, I just took the
copymethod test files as a blueprint, and it seems we can make some refactoring here and there. I'm open to any suggestions!