feat(components): showMore component customization #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmh
commented
Mar 13, 2024
Comment on lines
+88
to
+95
| action( | ||
| `custom showMore component clicked with props: ${JSON.stringify( | ||
| showMoreProps, | ||
| null, | ||
| 2 | ||
| )}` | ||
| ) | ||
| }} |
There was a problem hiding this comment.
I passed the props in the action hoping to visualize the values in the actions panel, but the panel is not showing any actions at the moment, is it broken?
davidmh
force-pushed
the
feature/show-more-customizations
branch
from
a681825
to
2eea37e
Compare
I'm trying to render a custom component for the `show more` button. I know there are a few recommended ways to do this through the `onShowMore` callback and the `messages.showMore` prop as suggested in jquense#1147. But that doesn't cover all use cases. For example, I want to access the events that are being hidden by the `show more` button. I also want to render a custom popup right next to the `show more` button. Resolves jquense#2391
davidmh
force-pushed
the
feature/show-more-customizations
branch
from
2eea37e
to
770be8b
Compare
davidmh
commented
Mar 14, 2024
| return count ? ( | ||
| <ShowMore | ||
| localizer={localizer} | ||
| slotDate={slotMetrics.getDateForSlot(slot - 1)} |
There was a problem hiding this comment.
The getDateForSlot access the slots range, and array, using the slot as the index. But the slot received in this method are not zero-based, which means, we need to adjust for the expected zero-based index used to pull from the range:
react-big-calendar/src/utils/DateSlotMetrics.js
Lines 38 to 40 in 12d81f0
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to render a custom component for the
show morebutton. I know there are a few recommended ways to do this through theonShowMorecallback and themessages.showMoreprop as suggested in #1147.But that doesn't cover all use cases. For example, I want to access the events that are being hidden by the
show morebutton. I also want to render a custom popup right next to theshow morebutton.This new component adds the following props:
I can also update the types once this gets merged.
Resolves #2391
I tried reaching out through the Slack community first, but the invitation link has expired, could you post a new link?