Recalculate "more" with ResizeObserver #2573
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Think you're on the right track, but seeing a big difference right now, just from the landing page of the documentation |
|
Updated that finds first week with an event. Also disables oberve when showAllEvents is enabled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that in month view "+n more" button didn't recalculate, when calendar's size changed, only on date navigation.
Updated that it recalculates using ResizeObserver
Fixes #828
Also removed dummy rows for measurements. Using only real rows if one exist, so eventWrapper with a different event height should calculate "more" correctly, though assuming that the "more" is the same height as event rows