Fixed logic in "42" tests #2203
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in the "42" tests was backwards. It was checking that the number didn't equal 42, when it should check the number does equal 42.
jquense
reviewed
Apr 28, 2024
| @@ -779,7 +779,7 @@ For instance this will work: | |||
| let schema = number().test( | |||
| 'is-42', | |||
| "this isn't the number i want", | |||
| (value) => value != 42, | |||
| (value) => value === 42, | |||
There was a problem hiding this comment.
Suggested change
| (value) => value === 42, | |
| (value) => value == null || value === 42, |
There was a problem hiding this comment.
Are you saying you want the test to pass if the value is null?
There was a problem hiding this comment.
if its undefined or null. that is handled by required, defined etc
jquense
reviewed
Apr 28, 2024
| @@ -789,7 +789,7 @@ however this will not: | |||
|
|
|||
| ```js | |||
| let schema = number().test('is-42', "this isn't the number i want", (value) => | |||
| Promise.resolve(value != 42), | |||
| Promise.resolve(value === 42), | |||
There was a problem hiding this comment.
Suggested change
| Promise.resolve(value === 42), | |
| Promise.resolve(value == null || value === 42,), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic in the "42" tests was backwards. It was checking that the number didn't equal 42, when it should check the number does equal 42.