Updated cache:true instructions for $.getScript #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of passing a settings object instead of URL string was added on jQuery 1.12 but not documented. Added the signature and updated the cache related workarounds and examples to reflect the new signature. The example with loading jquery-color was edited to support caching because browser caching is highly recommended when loading a plugin code.
The signature of passing a settings object instead of URL string was added on jQuery 1.12. Added the signature and updated the workarounds and examples to reflect the new signature. The example of loading jquery-color was edited to support caching because browser caching is highly recommended when loading a plugin code.
oriadam
changed the title
|
Hi @oriadam, thank you for your contribution. Could you update the examples in your PR to match our style guide? You can find the guide here: https://contribute.jquery.org/style-guide/js/ |
|
Hi @AurelioDeRosa be glad to :) is it ok now ? |
|
We don't seem to have a style guide for XML documents. The one that @AurelioDeRosa links to describes only JS. We have an HTML doc but our XML files aren't really close to that. @oriadam I think all XML files should be aligned with each other so they should all use 2-space indentation. |
mgol
requested changes
Aug 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$.getScript signature of passing a settings object instead of URL string was added on jQuery 1.12.
Added the signature to documentation and updated the related workarounds and examples to include the new signature.
The example with loading jquery-color was edited to support caching, as caching is highly recommended when loading a plugin.