jQuery.ajax: Fix #1022 #1105
Open
jQuery.ajax: Fix #1022 #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix jquery#1022
|
|
| @@ -160,7 +160,7 @@ $.ajax({ | |||
| } | |||
| }); | |||
| </code></pre> | |||
| <p>If the request is successful, the status code functions take the same parameters as the success callback; if it results in an error (including 3xx redirect), they take the same parameters as the <code>error</code> callback.</p> | |||
| <p>If the request is successful, the status code functions take the same parameters as the success callback; if it results in an error (including 3xx redirects to another domain), they take the same parameters as the <code>error</code> callback. (3xx redirects to the same domain are generally handled transparently.)</p> | |||
There was a problem hiding this comment.
Can you be more explicit about what "generally" means here?
There was a problem hiding this comment.
"generally handled transparently" is vague, I agree. Perhaps "3xx redirects to the same domain are handled by the browser and not contrlled by jQuery."
|
@zyphlar Do you plan to finish the PR? |
mgol
requested changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix #1022