Skip to content

Commit

Permalink
Offset: Increase search depth when finding the 'real' offset parent
Browse files Browse the repository at this point in the history
Changes:
* Increase search depth when finding for the real offset parent
* Ignore offset for statically positioned offset parent
* Add tests for the position of an element in a table

Closes gh-4861
  • Loading branch information
Minimaximize committed Apr 19, 2024
1 parent df1df95 commit 556eaf4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
7 changes: 4 additions & 3 deletions src/offset.js
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,13 @@ jQuery.fn.extend( {
doc = elem.ownerDocument;
offsetParent = elem.offsetParent || doc.documentElement;
while ( offsetParent &&
( offsetParent === doc.body || offsetParent === doc.documentElement ) &&
offsetParent !== doc.documentElement &&
jQuery.css( offsetParent, "position" ) === "static" ) {

offsetParent = offsetParent.parentNode;
offsetParent = offsetParent.offsetParent || doc.documentElement;
}
if ( offsetParent && offsetParent !== elem && offsetParent.nodeType === 1 ) {
if ( offsetParent && offsetParent !== elem && offsetParent.nodeType === 1 &&
jQuery.css( offsetParent, "position" ) !== "static" ) {

// Incorporate borders into its offset, since they are outside its content origin
parentOffset = jQuery( offsetParent ).offset();
Expand Down
5 changes: 4 additions & 1 deletion test/unit/offset.js
Original file line number Diff line number Diff line change
Expand Up @@ -436,13 +436,16 @@ testIframe( "fixed", "offset/fixed.html", function( assert, $, window ) {
} );

testIframe( "table", "offset/table.html", function( assert, $ ) {
assert.expect( 4 );
assert.expect( 6 );

assert.equal( $( "#table-1" ).offset().top, 6, "jQuery('#table-1').offset().top" );
assert.equal( $( "#table-1" ).offset().left, 6, "jQuery('#table-1').offset().left" );

assert.equal( $( "#th-1" ).offset().top, 10, "jQuery('#th-1').offset().top" );
assert.equal( $( "#th-1" ).offset().left, 10, "jQuery('#th-1').offset().left" );

assert.equal( $( "#th-1" ).position().top, 10, "jQuery('#th-1').position().top" );
assert.equal( $( "#th-1" ).position().left, 10, "jQuery('#th-1').position().left" );
} );

testIframe( "scroll", "offset/scroll.html", function( assert, $, win ) {
Expand Down

0 comments on commit 556eaf4

Please sign in to comment.