add ability to warn or fail a test if a seed is fixed #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
introduce a `FixedSeedMode` that can be set globally (via properties) or on an individual test. this allows control of using the `seed` argument on a property, as it can be undesirable to accidentally commit a value in this field after reproducing a failure.
osi
commented
Jan 20, 2021
engine/src/main/java/net/jqwik/engine/execution/CheckedProperty.java
Outdated
Show resolved
Hide resolved
|
@osi Do you think it's ready for merging? |
|
I believe it's ready. The CI failure seems like a permission issue of some sort. |
|
Yes, CI is on me.
Von meinem iPad gesendet
… Am 22.01.2021 um 00:25 schrieb peter royal ***@***.***>:
I believe it's ready. The CI failure seems like a permission issue of some sort.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
jlink
requested changes
Jan 22, 2021
| @@ -55,7 +55,17 @@ public CheckedProperty( | |||
| } | |||
|
|
|||
| public PropertyCheckResult check(Reporting[] reporting) { | |||
| PropertyConfiguration effectiveConfiguration = configurationWithEffectiveSeed(); | |||
| PropertyConfiguration effectiveConfiguration; | |||
| try { | |||
There was a problem hiding this comment.
I think this try-catch block has a better place in method configurationWithEffectiveSeed()
There was a problem hiding this comment.
The problem with moving into that method is that the try-catch block translates the exception to a PropertyCheckResult.
I extracted the handling of the exception into a helper method, as the same work is done twice. perhaps that's sufficient for now?
engine/src/main/java/net/jqwik/engine/execution/CheckedProperty.java
Outdated
Show resolved
Hide resolved
I'll take care of them in the next few days. I appreciate the suggestions! |
|
Many thanks. Going to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce a
FixedSeedModethat can be set globally (via properties)or on an individual test. this allows control of using the
seedargument on a property, as it can be undesirable to accidentally commit
a value in this field after reproducing a failure.
fix for #138