Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release): support bitbucket cloud releases #1389

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

viqueen
Copy link

@viqueen viqueen commented May 17, 2023

Fixes #12

Context

  • supports releasing to bitbucket cloud repository
  • it does not include resolving an issue tracker (yet) , to be continued
    • we can support default issue tracker first with bitbucket cloud group issue tracker api
    • and explore integration with jira for [version/release management}(https://support.atlassian.com/jira-software-cloud/docs/enable-releases-and-versions/)
  • it includes artifact upload to bitbucket cloud
  • note:
    • I ran into some issues with git push using ssh locally, other than that everything works fine with repo access tokens and https remotes

Checklist

@CLAassistant
Copy link

CLAassistant commented May 17, 2023

CLA assistant check
All committers have signed the CLA.

@viqueen viqueen changed the title Issue/jreleaser 12 support bitbucket cloud releases #12 support bitbucket cloud releases May 17, 2023
@viqueen viqueen force-pushed the issue/JRELEASER-12-support-bitbucket-cloud-releases branch from 8fa7c59 to 62d5137 Compare May 17, 2023 03:28
@viqueen viqueen changed the title #12 support bitbucket cloud releases feat(release) support bitbucket cloud releases May 17, 2023
@viqueen viqueen changed the title feat(release) support bitbucket cloud releases feat(release): support bitbucket cloud releases May 17, 2023
@viqueen viqueen force-pushed the issue/JRELEASER-12-support-bitbucket-cloud-releases branch from 2d39d1e to c6c4a70 Compare May 17, 2023 03:42
@aalmiray
Copy link
Member

Is there a significant API difference between BBC and BBS? I'd suppose some would like to use their own BBS instance when running on premise.

@viqueen viqueen force-pushed the issue/JRELEASER-12-support-bitbucket-cloud-releases branch from c6c4a70 to f0eb8d1 Compare May 17, 2023 05:26
@viqueen
Copy link
Author

viqueen commented May 17, 2023

Is there a significant API difference between BBC and BBS? I'd suppose some would like to use their own BBS instance when running on premise.

Historically they are different products, so there's definitely a difference in the API endpoints, but also in access token management.

@aalmiray
Copy link
Member

Would it make sense to support both with a single DSL element named bitbucket and additional enum property mode with CLOUD and SERVER as value?

The reason I ask is that both GitHub and Gitlab support managed and self hosted services with a single DSL element because the only difference at the moment is the host's value, given that the API is the same for both scenarios.

@aalmiray
Copy link
Member

I'm thinking that support for BBS may be added later based on user request. Both BBC & BBS could be supported by a single DSL element as previously suggested, in which case bitbucketcloud would be deprecated in favor of bitbucket.

}

try {
Response response = api.uploadArtifact(uploader.getProjectIdentifier(), uploader.getPackageName(), path);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

project identifier might contain name templates which should be resolved before calling the api. Use Templates.resolveTemplate() to get the resolved value.

* @author Hasnae Rehioui
* @since 1.7.0
*/
public class BitbucketcloudUploader extends AbstractGitPackageUploader<org.jreleaser.model.api.upload.BitbucketcloudUploader, BitbucketcloudUploader> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This uploader should be registered with JsonSchemaGenerator in the same way as others uploaders have been registered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[release] Support releasing to Bitbucket
3 participants