-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release): support bitbucket cloud releases #1389
base: main
Are you sure you want to change the base?
feat(release): support bitbucket cloud releases #1389
Conversation
8fa7c59
to
62d5137
Compare
2d39d1e
to
c6c4a70
Compare
(cherry picked from commit 62d5137)
Is there a significant API difference between BBC and BBS? I'd suppose some would like to use their own BBS instance when running on premise. |
c6c4a70
to
f0eb8d1
Compare
Historically they are different products, so there's definitely a difference in the API endpoints, but also in access token management. |
Would it make sense to support both with a single DSL element named The reason I ask is that both GitHub and Gitlab support managed and self hosted services with a single DSL element because the only difference at the moment is the host's value, given that the API is the same for both scenarios. |
I'm thinking that support for BBS may be added later based on user request. Both BBC & BBS could be supported by a single DSL element as previously suggested, in which case |
...er-model-impl/src/main/java/org/jreleaser/model/internal/release/BitbucketcloudReleaser.java
Show resolved
Hide resolved
} | ||
|
||
try { | ||
Response response = api.uploadArtifact(uploader.getProjectIdentifier(), uploader.getPackageName(), path); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
project identifier might contain name templates which should be resolved before calling the api. Use Templates.resolveTemplate()
to get the resolved value.
* @author Hasnae Rehioui | ||
* @since 1.7.0 | ||
*/ | ||
public class BitbucketcloudUploader extends AbstractGitPackageUploader<org.jreleaser.model.api.upload.BitbucketcloudUploader, BitbucketcloudUploader> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This uploader should be registered with JsonSchemaGenerator in the same way as others uploaders have been registered.
Fixes #12
Context
Checklist
Review Contribution Guidelines.
Make sure all contributed code can be distributed under the terms of the
Apache License 2.0, e.g. the code was written by
you or the original code is licensed under a license compatible to Apache License 2.0.
Update documentation when applicable.
register BitbucketcloudUploader with JsonSchemaGenerator
use
Templates.resolveTemplate()
where applicableuse
bitbucket
dsl withmode
set to CLOUD vs DC/SERVER