check for null when calling Storage::readStream()

jrmajor · May 4, 2024 · 2a9d081 · 2a9d081
1 parent 4c28264
commit 2a9d081
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/app/Images/Exceptions/FailedToReadStream.php b/app/Images/Exceptions/FailedToReadStream.php
@@ -0,0 +1,14 @@
+<?php
+
+namespace App\Images\Exceptions;
+
+use Exception;
+
+class FailedToReadStream extends Exception
+{
+    public function __construct(
+        public string $path,
+    ) {
+        parent::__construct("Failed to read stream for file at {$this->path}.");
+    }
+}
diff --git a/app/Images/Image.php b/app/Images/Image.php
@@ -2,6 +2,7 @@
 
 namespace App\Images;
 
+use App\Images\Exceptions\FailedToReadStream;
 use App\Images\Exceptions\OriginalDoesNotExist;
 use Carbon\Carbon;
 use Illuminate\Database\Eloquent\Model;
@@ -155,7 +156,8 @@ protected function deleteResponsiveVariants(): bool
      */
     public function readStream()
     {
-        return static::disk()->readStream($this->originalPath());
+        return static::disk()->readStream($path = $this->originalPath())
+            ?? throw new FailedToReadStream($path);
     }
 
     public static function disk(): FilesystemAdapter