Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all() method and tests #822

Closed
wants to merge 1 commit into from

Conversation

maxwellgerber
Copy link

This is a reference PR for #813 that adds all(): Array<{ name: string, value: string }>

This PR adds ~50 bytes to the final bundle size, keeping dist/js.cookie.min.mjs just barely under the 800 byte limit when gzipped.

This PR also adds a testcase that uses an iframe to create a scenario in which the same cookie name is set multiple times, with different values.

Running "compare_size:files" (compare_size) task
   raw     gz Sizes                                                            
  4052   1439 dist/js.cookie.mjs                                               
  1560    778 dist/js.cookie.min.mjs                                           
  4806   1625 dist/js.cookie.js                                                
  1863    893 dist/js.cookie.min.js                                            

   raw     gz Compared to main @ ab3f67fc4fad88cdf07b258c08e4164e06bf7506      
  +577   +194 dist/js.cookie.mjs                                               
  +132    +51 dist/js.cookie.min.mjs                                           
  +617   +196 dist/js.cookie.js                                                
  +132    +54 dist/js.cookie.min.js  

Copy link
Contributor

This pull request has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@github-actions github-actions bot added the Stale label Nov 26, 2023
@github-actions github-actions bot closed this Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

1 participant