Workaround missing dispatch bailout #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 12, 2021 19:38
After raising this issue (CharlesStover/reactn#215 (comment)) I'm happy to add this workaround setter which will be used instead of the existing dispatches in this components hooks. I will keep the reducers as they are, leaving the logic which determines whether to return the previous or next property *in* the reducers so that they would still be applicable to dispatch as would be the "proper" design.
See previous commit for details.
It turns out that `reduce-harpstrata-to-rootpitchid` was implemented incorrectly, but it wasn't picked up by the test because harpKeyId and rootPitchId are the same in first position. Updating the position of this base test data in to second position makes this kind of false positive less likely. Several test files have had to be updated along with this change.
js-jslog
merged commit 74e2142
into
simplify-global-source-state-callbacks-with-dispatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As raised here we need a workaround to avoid the many unnecessary renders that this strategy will otherwise produce.
I'm happy with this. It's just about as readable as the original design and only introduces a very small surface area to be tested.
The reason so many files are involved included in this diff now has more to do with this change revealing a gap in the test data setup which is best filled to avoid false positives as was experienced in this branch. See commit history for details; there's only 3 of them in this pull request.