Skip to content

Commit

Permalink
Version 24.0.0
Browse files Browse the repository at this point in the history
  • Loading branch information
domenic committed Jan 21, 2024
1 parent db0a4dc commit 2f8a730
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 4 deletions.
1 change: 1 addition & 0 deletions .mailmap
Expand Up @@ -25,3 +25,4 @@ Christoph Pojer <christoph.pojer@gmail.com>
Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
Jesus David Garcia Gomez <jdgarcia@outlook.com> <dgarcia@plainconcepts.com>
Magne Andersson <code@zirro.se>
asamuzaK (Kazz) <kazz@asamuzak.jp> <asamuzaK@users.noreply.github.com>
1 change: 0 additions & 1 deletion AUTHORS.txt
Expand Up @@ -32,7 +32,6 @@ antonj <anton.johansson@gmail.com>
Aria Stewart <aredridel@nbtsc.org>
Arrix <arrixzhou@gmail.com>
Aryan Arora <aryanarora278@gmail.com>
asamuzaK (Kazz) <asamuzaK@users.noreply.github.com>
asamuzaK (Kazz) <kazz@asamuzak.jp>
Avery Fay <avery@mixpanel.com>
Avi Deitcher <avi@deitcher.net>
Expand Down
10 changes: 10 additions & 0 deletions Changelog.md
Expand Up @@ -26,6 +26,16 @@ Other guidelines:
* Roughly order changes within those groupings by impact.
-->

## 24.0.0

This release reverts our selector engine back to [`nwsapi`](https://www.npmjs.com/nwsapi). As discussed in [#3659](https://github.com/jsdom/jsdom/issues/3659), the performance regressions from [`@asamuzakjp/dom-selector`](https://www.npmjs.com/package/@asamuzakjp/dom-selector) turned out to be higher than anticipated. In the future, we can revisit `@asamuzakjp/dom-selector` after it reaches `nwsapi`'s performance on the [two real-world benchmarks provided by the community](https://github.com/jsdom/jsdom/issues/3659#issuecomment-1890852609).

Since reverting to `nwsapi` causes several functionality regressions, e.g. removing `:has()` support, we've decided to make this a major version.

Additionally:

* Small fixes to edge-case behavior of the following properties: `input.maxLength`, `input.minLength`, `input.size`, `progress.max`, `tableCell.colSpan`, `tableCell.rowSpan`, `tableCol.span`, `textArea.cols`, `textArea.maxLength`, `textArea.minLength`, `textArea.rows`.

## 23.2.0

This release switches our CSS selector engine from [`nwsapi`](https://www.npmjs.com/nwsapi) to [`@asamuzakjp/dom-selector`](https://www.npmjs.com/package/@asamuzakjp/dom-selector). The new engine is more actively maintained, and supports many new selectors: see [the package's documentation](https://github.com/asamuzaK/domSelector#supported-css-selectors) for the full list. It also works better with shadow trees.
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
@@ -1,6 +1,6 @@
{
"name": "jsdom",
"version": "23.2.0",
"version": "24.0.0",
"description": "A JavaScript implementation of many web standards",
"keywords": [
"dom",
Expand Down

0 comments on commit 2f8a730

Please sign in to comment.